<html>
<head><meta charset="utf-8"><title>New bootstrap rustfmt doesn&#x27;t support syntax from sept? · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/New.20bootstrap.20rustfmt.20doesn&#x27;t.20support.20syntax.20from.20sept.3F.html">New bootstrap rustfmt doesn&#x27;t support syntax from sept?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="213098097"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/New%20bootstrap%20rustfmt%20doesn%27t%20support%20syntax%20from%20sept%3F/near/213098097" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/New.20bootstrap.20rustfmt.20doesn&#x27;t.20support.20syntax.20from.20sept.3F.html#213098097">(Oct 13 2020 at 00:05)</a>:</h4>
<p>The current rustfmt used for tidy looks like it's nightly-2020-10-07 <a href="https://github.com/rust-lang/rust/pull/77682/files#diff-1ae19efd6261ade130cb816d6c2d6951800320561d6834f0785c60469b9d8815R23">https://github.com/rust-lang/rust/pull/77682/files#diff-1ae19efd6261ade130cb816d6c2d6951800320561d6834f0785c60469b9d8815R23</a></p>
<p>But in <a href="https://github.com/rust-lang/rust/pull/77877/checks?check_run_id=1244832194">https://github.com/rust-lang/rust/pull/77877/checks?check_run_id=1244832194</a> I'm getting a syntax error that I fixed in rustc on 2020-09-07 (PR <a href="https://github.com/rust-lang/rust/pull/76274">https://github.com/rust-lang/rust/pull/76274</a>)</p>
<p>Did I need to do something to pick up this change in rustfmt?  Note that <code>check</code> <a href="https://github.com/rust-lang/rust/pull/77877/checks?check_run_id=1244832194#step:24:1253">passed</a> for the change; it's just rustfmt that's unhappy with it.</p>



<a name="213099468"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/New%20bootstrap%20rustfmt%20doesn%27t%20support%20syntax%20from%20sept%3F/near/213099468" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/New.20bootstrap.20rustfmt.20doesn&#x27;t.20support.20syntax.20from.20sept.3F.html#213099468">(Oct 13 2020 at 00:31)</a>:</h4>
<p>sounds like a rustfmt bug</p>



<a name="213109332"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/New%20bootstrap%20rustfmt%20doesn%27t%20support%20syntax%20from%20sept%3F/near/213109332" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/New.20bootstrap.20rustfmt.20doesn&#x27;t.20support.20syntax.20from.20sept.3F.html#213109332">(Oct 13 2020 at 03:49)</a>:</h4>
<p>Hmm, looks like maybe it needs a manual dependency version bump in rustfmt to pick it up (like was done in <a href="https://github.com/rust-lang/rustfmt/pull/4433">https://github.com/rust-lang/rustfmt/pull/4433</a>)</p>
<p>Edit: Oh, might have happened in <a href="https://github.com/rust-lang/rustfmt/pull/4461">https://github.com/rust-lang/rustfmt/pull/4461</a>.</p>
<p>I wonder what the rules are for bumping the rustfmt version in tidy?  Do I need to wait another 5 weeks?</p>



<a name="213144259"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/New%20bootstrap%20rustfmt%20doesn%27t%20support%20syntax%20from%20sept%3F/near/213144259" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/New.20bootstrap.20rustfmt.20doesn&#x27;t.20support.20syntax.20from.20sept.3F.html#213144259">(Oct 13 2020 at 12:09)</a>:</h4>
<p><span class="user-mention" data-user-id="125270">@scottmcm</span> You should feel free to bump at anytime.</p>



<a name="213144348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/New%20bootstrap%20rustfmt%20doesn%27t%20support%20syntax%20from%20sept%3F/near/213144348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/New.20bootstrap.20rustfmt.20doesn&#x27;t.20support.20syntax.20from.20sept.3F.html#213144348">(Oct 13 2020 at 12:10)</a>:</h4>
<p>We just don't want to do it without reason beyond ~cycleish bumps since it does mean a redownload for everyone and/or manual config changes if people are trying to be fancy</p>



<a name="213166107"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/New%20bootstrap%20rustfmt%20doesn%27t%20support%20syntax%20from%20sept%3F/near/213166107" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/New.20bootstrap.20rustfmt.20doesn&#x27;t.20support.20syntax.20from.20sept.3F.html#213166107">(Oct 13 2020 at 14:48)</a>:</h4>
<p>Thanks, <span class="user-mention" data-user-id="116122">@simulacrum</span>.  Should I do it in a separate PR, or just make it part of the PR that needs it?</p>



<a name="213167275"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/New%20bootstrap%20rustfmt%20doesn%27t%20support%20syntax%20from%20sept%3F/near/213167275" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/New.20bootstrap.20rustfmt.20doesn&#x27;t.20support.20syntax.20from.20sept.3F.html#213167275">(Oct 13 2020 at 14:55)</a>:</h4>
<p>part of is fine</p>



<a name="213167280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/New%20bootstrap%20rustfmt%20doesn%27t%20support%20syntax%20from%20sept%3F/near/213167280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/New.20bootstrap.20rustfmt.20doesn&#x27;t.20support.20syntax.20from.20sept.3F.html#213167280">(Oct 13 2020 at 14:55)</a>:</h4>
<p><span class="user-mention" data-user-id="125270">@scottmcm</span> ^</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>